Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix cross validation evaluation#337

Closed
lucasmoura wants to merge 5 commits intoaimacode:masteraimacode/aima-python:masterfrom
lucasmoura:fix_cross_validationlucasmoura/aima-python:fix_cross_validationCopy head branch name to clipboard
Closed

Fix cross validation evaluation#337
lucasmoura wants to merge 5 commits intoaimacode:masteraimacode/aima-python:masterfrom
lucasmoura:fix_cross_validationlucasmoura/aima-python:fix_cross_validationCopy head branch name to clipboard

Conversation

@lucasmoura
Copy link
Contributor

@lucasmoura lucasmoura commented Mar 8, 2017

The cross_validation function was not working on learning.py. Running the compare function, which is responsible for comparing multiple algorithms against their cross validation score would generate an error. With that said, this MR does the following:

  • Update cross_validation function to resemble more the book pseudocode
  • Update cross_validation_wrapper to resemble more the book pseudocode
  • Add tests to function train_and_test
  • Update print_table function on utils.py to better handle the cross validation output.
  • Add dummy size variable to some learner implementations, in order to maintain cross_validation similiarity with the book algorithm. This should be updated in the future, in order for the size parameter to be a way to better configure a learner.

@lucasmoura lucasmoura changed the title Fix cross_validation function Fix cross validation for learners Mar 8, 2017
@lucasmoura lucasmoura changed the title Fix cross validation for learners Fix cross validation evaluation Mar 8, 2017
@lucasmoura lucasmoura force-pushed the fix_cross_validation branch 3 times, most recently from 70dcee8 to f42ef9f Compare March 22, 2017 17:05
@lucasmoura
Copy link
Contributor Author

Updating this MR, because #388 already fixes the bug in leave one out cross validation

@lucasmoura
Copy link
Contributor Author

Updating this MR, because #471 already updated the print_table function for python3

@lucasmoura lucasmoura force-pushed the fix_cross_validation branch from 1af3c52 to 60b73a5 Compare April 7, 2017 18:44
@lucasmoura lucasmoura force-pushed the fix_cross_validation branch from 60b73a5 to 685e2a5 Compare April 18, 2017 12:14
@norvig norvig closed this Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.