This repository was archived by the owner on Oct 25, 2024. It is now read-only.
hs2019 with PSS support#22
Open
fulder wants to merge 33 commits intoahknight:masterahknight/httpsig:masterfrom
Open
hs2019 with PSS support#22fulder wants to merge 33 commits intoahknight:masterahknight/httpsig:masterfrom
fulder wants to merge 33 commits intoahknight:masterahknight/httpsig:masterfrom
Conversation
In order to be able to decode the PSS message, the salt length need to be known.
This was referenced Aug 25, 2020
|
+1 |
Default to hash length for salt in PSS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement support for new
hs2019algorithm together with PSS digital signature algorithm in order to follow the latest v12 draftAs the digital signature algorithm should now be derived from the
keyIdboth theSignerandVerifierclasses are now accepting a new (optional)sign_algorithmparameter which should be a subclass of the newSignAlgorithmsuperclass. This way we can easy add support for other digital signature algorithms by adding a custom class (implementing thesignandverifyfunctions).This has been implemented in parallel with the previously accepted algorithms (e.g.
rsa-sha256). This means these algorithms are still supported although a deprecation message is now printed while they are used and they should probably be removed in next major release of this library (together with some cleanup of the 'old' code).The
test_signaturetests has been updated to the newhs2019with one test left for the deprecatedrsa-sha256. TheREADMEfile has also been updated with the new algorithm.