fix: Virtualizer with useIsSSR #8320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
reidbarber
approved these changes
May 29, 2025
yihuiliao
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8293
In collaboration with @LFDanLu , we tried to write a test that mimicked what Next was doing in our SSR tests, but we couldn't get it to reproduce there. The flow diverges pretty quickly, in the test we immediately have a full collection, but in Next, there's a period of time where it's not been processed yet.
I'm assuming there is something happening with concurrency, but that's just a hunch. Open to suggestions on a test for this.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: