You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.rst
+3-15Lines changed: 3 additions & 15 deletions
Original file line number
Diff line number
Diff line change
@@ -15,19 +15,13 @@ Before sending us a Pull Request, please consider this list of points:
15
15
16
16
* Is the contribution entirely your own work, or already licensed under an LGPL 2.1 compatible Open Source License? If not then we unfortunately cannot accept it.
17
17
18
-
* Does any new code conform to the esp-idf :doc:`Style Guide <style-guide>`?
19
-
20
-
* Have you installed the :doc:`pre-commit hook <install-pre-commit-hook>` for esp-idf project?
21
-
22
-
* Does the code documentation follow requirements in :doc:`documenting-code`?
23
-
24
18
* Is the code adequately commented for people to understand how it is structured?
25
19
26
-
* Is there documentation or examples that go with code contributions? There are additional suggestions for writing good examples in :idf:`examples` readme.
20
+
* Is there documentation or examples that go with code contributions?
27
21
28
22
* Are comments and documentation written in clear English, with no spelling or grammar errors?
29
23
30
-
* Example contributions are also welcome. Please check the :doc:`creating-examples` guide for these.
24
+
* Example contributions are also welcome.
31
25
32
26
* If the contribution contains multiple commits, are they grouped together into logical changes (one major change per pull request)? Are any commits with names like "fixed typo" `squashed into previous commits <https://eli.thegreenplace.net/2014/02/19/squashing-github-pull-requests-into-a-single-commit/>`_?
0 commit comments