Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Wake Future when EOF is received #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
centromere wants to merge 1 commit into
base: main
Choose a base branch
Loading
from
Open

Wake Future when EOF is received #3492

centromere wants to merge 1 commit into from
+4 −0

Conversation

@centromere
Copy link

@centromere centromere commented Nov 1, 2024

PR Type

Bug fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

When a TCP FIN is received, the Future needs to be awakened. Without this, it is not possible to detect a connection closure in end-user applications.

Relates to: #3093

asonix
asonix approved these changes Nov 9, 2024
View reviewed changes
Copy link
Contributor

@asonix asonix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

actix-http/CHANGES.md Outdated Show resolved Hide resolved
actix-http/src/h1/payload.rs Show resolved Hide resolved
@robjtede robjtede added A-http project: actix-http B-semver-patch labels May 9, 2025
@centromere
Wake Future when EOF is received
785d02f 
When a TCP FIN is received, the Future needs to be awakened. Without this, it
is not possible to detect a connection closure in end-user applications.
@centromere
Copy link
Author

centromere commented May 30, 2025

@robjtede @asonix, may this get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@asonix asonix asonix approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

A-http project: actix-http B-semver-patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@centromere @asonix @robjtede
Morty Proxy This is a proxified and sanitized view of the page, visit original site.