Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Support installation of a specified Python version for Linux #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

SerVB
Copy link
Contributor

@SerVB SerVB commented Apr 14, 2020

Follow-up of #29.

I've forked and added support for installing custom version if it's not found.

This implementation is MVP, so:

Can it be accepted to the main repo? I'm ready for discussions!

P.S.: Any ideas how can I fix the problem with unchanged lines marked as changed in this PR? Maybe something related to line endings...

@SerVB
Copy link
Contributor Author

SerVB commented Apr 14, 2020

Oops, will investigate the failed test.

@SerVB
Copy link
Contributor Author

SerVB commented Apr 14, 2020

It seems that error in exec.exec crashes tests. I've added try catch around it, but that doesn't help. Any suggestions?

@SerVB
Copy link
Contributor Author

SerVB commented Apr 18, 2020

@konradpabjan, could you help? Or advise a place to ask?

@konradpabjan
Copy link
Contributor

@SerVB thanks for the PR! We have something new on the way for setup-python that downloads specific versions of python if they are not available. This will allow non-cached versions of python to be installed and it will work with Windows Linux & Mac. It should address the problem you're facing 😀

Check out this PR: #85

Can you open an issue in actions/python-versions for the 2.7.7 version of python.

In your example run it takes about 6 minutes to compile the specific version of Python, while downloading an already compiled package and installing it should take about 10 seconds. In python-versions we also compile with --enable-optimizations so it takes a lot longer to compile, but the binaries are little bit better so I think the best solution is to get 2.7.7 available in python-versions.

@konradpabjan
Copy link
Contributor

Sorry that we couldn't get 2.7.7 into python-versions 😕 The version is just too old and there were a lot of weird issues during compile time that we can't prioritize at the moment.

Based off of the consensus in actions/runner-images#810 I'll close out this PR. Thanks again for initially creating this PR and apologies that we can't support your specific use case.

@SerVB
Copy link
Contributor Author

SerVB commented May 8, 2020

@konradpabjan , and why don't you want to add a feature to compile any python version manually, as I propose here?

I don't understand why you see only two variants:

  • Precompile 2.7.7.
  • Don't support 2.7.7 at all.

This PR is not even about 2.7.7, it's more general :) #85 doesn't cover it.

@SerVB SerVB changed the title Support installation specified of Python version for Linux Support installation of a specified Python version for Linux May 8, 2020
@konradpabjan
Copy link
Contributor

@SerVB

We're trying to keep any compile logic outside of this action. Historically, where/how we compiled Python from source was closed source, however we recently moved everything to actions/python-versions and we pull everything from there now and any updates will take place there.

Maintaining compilation in this action and in another place is a maintenance burden that is hard to justify. It would also cause some confusion for users (do they download an already compiled version or do they have to download from source and build it themselves, or do they use an already installed version?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.