Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix cross-platform build matrix example #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Fix cross-platform build matrix example #65

merged 1 commit into from
Mar 5, 2020

Conversation

pastelmind
Copy link
Contributor

@pastelmind pastelmind commented Mar 5, 2020

This commit fixes a faulty Workflow example in the README, which may confuse users. The current example actually runs all jobs under ubuntu-latest, because matrix.os is not being used by the runs-on field.

When running a job under multiple OSes, the runs-on field must use the matrix.os context property, as described in this official documentation for a multi-OS build matrix.

Copy link

@madhurig madhurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@madhurig madhurig merged commit ebe4d7e into actions:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.