Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

Add support for JDKs with JavaFX#19

Closed
airsquared wants to merge 1 commit intoactions:masteractions/setup-java:masterfrom
airsquared:masterCopy head branch name to clipboard
Closed

Add support for JDKs with JavaFX#19
airsquared wants to merge 1 commit intoactions:masteractions/setup-java:masterfrom
airsquared:masterCopy head branch name to clipboard

Conversation

@airsquared
Copy link

@airsquared airsquared commented Aug 31, 2019 •
edited
Loading

I've tested this on my own repository, and it works well.

I wasn't sure what to set the name of the toolcache to, so I just changed it to 'fx-jdk' for JDKs with JavaFX and 'jdk' for JDKs without JavaFX (you might want to change this to something else).

To use this, just do:

- uses: airsquared/setup-java@master
  with:
    java-version: '1.8'
    javafx: true

Closes #18.

@airsquared
Add support for JDKs with JavaFX
654e4df 
Also changes the toolcache to 'fx-jdk' for JDKs with JavaFX and 'jdk' for JDKs without JavaFX
@airsquared airsquared mentioned this pull request Aug 31, 2019
Closed
@rmannibucau
Copy link

rmannibucau commented Sep 4, 2019

Hi,

can it be integrated please?

@airsquared
Copy link
Author

airsquared commented Sep 4, 2019

What do you mean by "integrated"?

@rmannibucau
Copy link

rmannibucau commented Sep 4, 2019

Merged, it prevents me to use gh actions and i'd like to avoid to fork the download logic again.

This was referenced Sep 14, 2019
Merged
Closed
@Hoto-Cocoa Hoto-Cocoa mentioned this pull request Sep 17, 2019
Open
@giltene
Copy link
Contributor

giltene commented Nov 3, 2019

I've created a separate pull request #27 that covers the requested feature but with a different syntax than the one proposed here: The change introduces a new java-package option that supports jre, jdk, and jdk+fx as accepted values (defaults to jdk and retains current behavior unless jre or jdk+fx is specified). I believe that this syntax (a single option to cover current and possible future package types) is preferable to having individual booleans per package type.

The action is available for testing as foo-actions/setup-java@master

@konradpabjan
Copy link
Contributor

konradpabjan commented Nov 22, 2019

Support for JavaFx was added with the following PR: #27

The README has also been updated with some information about how to use it.

I've also updated the releases tag so as long as you're using actions/setup-java@v1 then you should just be able to switch one of the parameters to use javafx

RVRX added a commit to RVRX/GoICasterCompanion that referenced this pull request Jul 16, 2021
@RVRX
add javaFX to JDK
73cd801 
per actions/setup-java#19
@scooby22400 scooby22400 mentioned this pull request Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for JavaFX builds

4 participants

@airsquared @rmannibucau @giltene @konradpabjan
Morty Proxy This is a proxified and sanitized view of the page, visit original site.