Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add breaking change warning to 'main' branch#138

Merged
maxim-lobanov merged 2 commits intomainactions/setup-java:mainfrom
add-main-warningactions/setup-java:add-main-warningCopy head branch name to clipboard
Mar 22, 2021
Merged

Add breaking change warning to 'main' branch#138
maxim-lobanov merged 2 commits intomainactions/setup-java:mainfrom
add-main-warningactions/setup-java:add-main-warningCopy head branch name to clipboard

Conversation

@maxim-lobanov
Copy link
Contributor

Description:
This PR adds warning for people who pinned their workflows to main branch.
We are not going to cut new release from main branch with these changes so this warning won't affect v1 customers.
This warning will be removed at 5th April when we push v2-preview branch to main

Related issue:
#137

src/setup-java.ts Outdated Show resolved Hide resolved
Co-authored-by: Konrad Pabjan <konradpabjan@github.com>
Copy link
Contributor

@konradpabjan konradpabjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to run ncc to update the warning in index.js as well. Gets me every time

@maxim-lobanov maxim-lobanov merged commit 9c7940b into main Mar 22, 2021
tdfacer pushed a commit to ifit/setup-java that referenced this pull request Oct 7, 2025
* add warning

* Update src/setup-java.ts

Co-authored-by: Konrad Pabjan <konradpabjan@github.com>

Co-authored-by: Konrad Pabjan <konradpabjan@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.