Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Is gpg-argument '--pinentry-mode loopback' still necessary? #271

Copy link
Copy link
@HannesWell

Description

@HannesWell
Issue body actions

Description:
The documentation of the setup-java action states that for the maven-gpg-plugin the gpgArguments should be configured to be --pinentry-mode loopback in order to "to pick up the gpg.passphrase value defined in Maven settings.xml." and consequently avoid failures of the signing process (this was added with PR #122).

But I just set up a Maven build that includes GPG signing and succeeds even tough the --pinentry-mode loopback arguments in the maven-gpg-plugin are not set.

Therefore I wonder if these arguments are still necessary? Maybe due to updates to GPG or the version used in the GH runners or maybe there is some magic environment configuration in the GH runners themself? I'm neither very familiar with GPG nor with the GitHub Action runners, so I cannot tell.
I just noticed that it worked for me even for several builds without that configuration. Or have I just been lucky and could get the errors mentioned in the document in some day?

Task version:
v2

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Repro steps:
Set up a usual Maven build that includes gpg signing, but without specifying the --pinentry-mode loopback arguments for the gpg-process like I did here:
https://github.com/axkr/symja_android_library/blob/master/symja_android_library/pom.xml
The GH-workflow used to perform the build is:
https://github.com/axkr/symja_android_library/blob/master/.github/workflows/maven-build-master-and-publish-snapshot.yml

Expected behavior:
Failure of the GPG signing process.

Actual behavior:
Signing completed successfully.

Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.