Implement DNS API for Efficientip SOLIDserver #6333
Conversation
|
Welcome |
|
Waiting for feedback. Thanks in advance. |
|
Well I'm surprised, the error in the run you refer is not with the code associated with the PR. I have re-sync my branch with the official repo. All checks are passing: https://github.com/EfficientIP-Labs/acme.sh/actions/runs/14923396036/job/41922851791 @neilpang, would you be kind to give it a new try ? Kind regards. |
dnsapi/dns_efficientip.sh
Outdated
| export _H2="Authorization: Basic ${EfficientIP_CredsEncoded}" | ||
| else | ||
| TS=$(date +%s) | ||
| Sig=$(printf "%b\n$TS\nPOST\n$baseurlnObject" "${EfficientIP_Token_Secret}" | openssl dgst -sha3-256 | cut -d '=' -f 2 | tr -d ' ') |
There was a problem hiding this comment.
can you not use the openssl here?
you can use the functin _digest
There was a problem hiding this comment.
Well I can indeed, but I would then need to modify the following line in the acme.sh file to include the sha3-256 digest:
_digest() {
...
if [ "$alg" = "sha3-256" ] || [ "$alg" = "sha256" ] || [ "$alg" = "sha1" ] || [ "$alg" = "md5" ]; then
...
Would that be ok ?
|
Proposed changes address your request. All DNS-API-Test are passing in my branch (https://github.com/EfficientIP-Labs/acme.sh/actions/runs/15239890351). |
|
it seems that zerossl is down: https://status.zerossl.com/ |
|
@neilpang is there anything else I can do to move forward with this pull request ? |
|
@neilpang all tests have finally passed: https://github.com/EfficientIP-Labs/acme.sh/actions/runs/15588147930 If you have the opportunity, can you trigger the pending workflows ? Kind regards |
dnsapi/dns_efficientip.sh
Outdated
| export _H2="Authorization: Basic $EfficientIP_CredsEncoded" | ||
| else | ||
| TS=$(date +%s) | ||
| Sig=$(printf "%b\n$TS\nDELETE\n${baseurlnObject}" "${EfficientIP_Token_Secret}" | openssl dgst -sha3-256 | cut -d '=' -f 2 | tr -d ' ') |
|
Sincere apologies, I don't know how I missed it... |
|
interested in this one for proxmox @neilpang . Thanks in advance |
|
@neilpang could you please re-run the check that fails for external reasons (Seems like some kind of rate limiting from cloudflare) ? Seeing this code integrated natively in your project would make life easier for many of my contacts. Thanks in advance. |
|
I can not rerun it. please make a new push |
dnsapi/dns_efficientip.sh
Outdated
| @@ -0,0 +1,139 @@ | ||
| #!/bin/sh |
|
your latest run is not passing: https://github.com/EfficientIP-Labs/acme.sh/actions/runs/18615493475 |
|
@neilpang - Finally got all tests to pass: https://github.com/EfficientIP-Labs/acme.sh/actions/runs/19298599984 It is quite confusing that this test suite very often fails for reasons completely external to the script itself. I hope this will permit to move forward. Kind regards |
|
Hello @neilpang, |
Implement DNS API for EfficientIP SOLIDserver DNS providers.