Add importer for project KB MSR2019 dataset#260
Merged
pombredanne merged 1 commit intoaboutcode-org:mainaboutcode-org/vulnerablecode:mainfrom Sep 28, 2020
Merged
Add importer for project KB MSR2019 dataset#260pombredanne merged 1 commit intoaboutcode-org:mainaboutcode-org/vulnerablecode:mainfrom
pombredanne merged 1 commit intoaboutcode-org:mainaboutcode-org/vulnerablecode:mainfrom
Conversation
pombredanne
requested changes
Sep 28, 2020
Member
pombredanne
left a comment
There was a problem hiding this comment.
Thanks. See my few nits inline.
I wonder if the format will be different in "kaybee" ?
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
pombredanne
approved these changes
Sep 28, 2020
| advsiories = [] | ||
| for row in csv_reader: | ||
| vuln_id, proj_home, fix_commit, _ = row | ||
| commit_link = proj_home + "/commit/" + fix_commit |
Member
There was a problem hiding this comment.
Nit: I would tend to prefer a .format or an f-string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shivam Sandbhor shivam.sandbhor@gmail.com