Add functionary support #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed functionary is specific to a model even though grammar is general enough to support any model (unless I'm misunderstanding something here). Not a big deal as I still haven't had time to look at the updates yet. I'll be doing that tonight and tomorrow. I'll (hopefully) know and understand more about the status quo by then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds support for proper OpenAI function calling using the functionary language model.
This model is capable of performing openai style funciton calling, selecting functions dynamically, and regular chat completions.
Link to model in GGUF format
Notes
It was straightforward enough to fit Functionary's prompt formatting into the new format method
and the quantized model behaves as expected however it's clear that the current API is inadequate to handle function calling properly
To do this correctlly we need to
:character) to see if any function is called while not returning any of the generated tokens up until that point.Update: It Works!