Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Disable Windows+CUDA workaround when compiling for HIPBLAS #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 4, 2024
Merged

Disable Windows+CUDA workaround when compiling for HIPBLAS #1493

merged 3 commits into from
Jun 4, 2024

Conversation

Engininja2
Copy link
Contributor

When compiling for the HIP SDK version 5.7 on Windows I get the following error.

      CMake Error at C:/Users/Engininja2/AppData/Local/Temp/tmptb9uvli3/build/cmake_install.cmake:241 (file):
        file INSTALL cannot find "C:/Program Files/AMD/ROCm/5.7/bin/amdhip64.dll":
        File exists.

AMD's CMake files have CMake looking in the SDK for amdhip64.dll but it's included with the gpu driver in C:\Windows\System32
This PR avoids including it and other runtime dlls when compiled for HIP.

abetlen
abetlen reviewed Jun 1, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
abetlen
abetlen requested changes Jun 1, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@Engininja2 @abetlen
change condition to check for Windows & CUDA
f77bffa 
Co-authored-by: Andrei <abetlen@gmail.com>
@abetlen abetlen merged commit ae5682f into abetlen:main Jun 4, 2024
@Engininja2 Engininja2 deleted the fix-windows-hip branch June 5, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetlen abetlen abetlen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Engininja2 @abetlen
Morty Proxy This is a proxified and sanitized view of the page, visit original site.