Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Check for existence of clip model path #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

kejcao
Copy link
Contributor

@kejcao kejcao commented Mar 8, 2024

The following code,

from llama_cpp.llama_chat_format import Llava15ChatHandler
Llava15ChatHandler(clip_model_path='this-path-does-not-exist')

When ran aborts and yields a core dump.

$ python3 main.py
Aborted (core dumped)

This PR installs a more graceful exception with an informative error message.

@abetlen
Copy link
Owner

abetlen commented Mar 9, 2024

@kejcao thank you for this!

@abetlen abetlen merged commit 1f3156d into abetlen:main Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.