Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat(low-level-api): Improve API static type-safety and performance #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2024
Merged

feat(low-level-api): Improve API static type-safety and performance #1205

merged 2 commits into from
Feb 21, 2024

Conversation

abetlen
Copy link
Owner

@abetlen abetlen commented Feb 21, 2024

  • Low level api calls now call directly into the loaded dll, not wrapped by a python function first. Reduces overhead however this now requires all low level calls to be positional argument only (this is type checked also).
  • Use NewType to wrap opaque pointers like ggml_context_p and ggml_model_p, improves static type safety

@abetlen abetlen merged commit 7f51b60 into main Feb 21, 2024
@abetlen abetlen deleted the improve-low-level-perf-and-type-safety branch February 26, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abetlen
Morty Proxy This is a proxified and sanitized view of the page, visit original site.