-
-
Notifications
You must be signed in to change notification settings - Fork 571
refactor, extract git definitions to git #6029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
breaking lots of things, see cross check
|
You removed types completely and changed all the usage. That was a lot of work... Why not keep the types in the defs interface but point them to the git defs? Keeping the following would reduce the impact to almost nothing: INTERFACE zif_abapgit_definitions.
TYPES:
ty_sha1 TYPE zif_abapgit_git_definitions=>ty_sha1,
ty_file TYPE zif_abapgit_git_definitions=>ty_file,
ty_files TYPE zif_abapgit_git_definitions=>ty_files,
ty_files_tt TYPE zif_abapgit_git_definitions=>ty_files_tt,
ty_file_signatures_tt TYPE zif_abapgit_git_definitions=>ty_file_signatures_tt,
ty_comment TYPE zif_abapgit_git_definitions=>ty_comment,
ty_item_state TYPE zif_abapgit_git_definitions=>ty_item_state, There are a few more I would move or you might need in /git:
|
well, having the same definitions multiple times, then it should be changed sometime anyhow? yea, there is always more to move
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moving on :-)
will see how much extra breakage there is 😁 |
#6029 (comment) somehow missed abapGit/CI (abapGit/CI#211) 😉 |
rule |
this is a start for extracting the git definitions to a new git definitions intf,
zif_abapgit_git_definitions
zif_abapgit_definitions
is getting too large, and its worth separating the responsibilities of the packagesthis is just a start, trying to keep the amount of changes small, but its difficult