From a0c79d649d53eca23d14757fff137a24d9000b7a Mon Sep 17 00:00:00 2001 From: Andreas Schmid Date: Sun, 9 Feb 2020 10:07:48 +0100 Subject: [PATCH 1/8] First attempt on github actions --- .github/workflows/gradle.yml | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 .github/workflows/gradle.yml diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml new file mode 100644 index 0000000..6f92108 --- /dev/null +++ b/.github/workflows/gradle.yml @@ -0,0 +1,25 @@ +name: Java CI + +on: [push] + +jobs: + build: + + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v2 + - name: Set up JDK 1.8 + uses: actions/setup-java@v1 + with: + java-version: 1.8 + - name: Prepare docker container for integration tests + - run: | + docker pull connectical/taskd + docker run -d --name=taskd -p 53589:53589 -v $(pwd)/docker/taskd:/var/taskd connectical/taskd + docker ps + + - name: Grant execute permission for gradlew + run: chmod +x gradlew + - name: Build with Gradle + run: ./gradlew build From 2f3d9ed2ba334c7073221796196e37e808a8ac6a Mon Sep 17 00:00:00 2001 From: Andreas Schmid Date: Sun, 9 Feb 2020 10:13:01 +0100 Subject: [PATCH 2/8] next try --- .github/workflows/gradle.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml index 6f92108..f9412d0 100644 --- a/.github/workflows/gradle.yml +++ b/.github/workflows/gradle.yml @@ -13,12 +13,6 @@ jobs: uses: actions/setup-java@v1 with: java-version: 1.8 - - name: Prepare docker container for integration tests - - run: | - docker pull connectical/taskd - docker run -d --name=taskd -p 53589:53589 -v $(pwd)/docker/taskd:/var/taskd connectical/taskd - docker ps - - name: Grant execute permission for gradlew run: chmod +x gradlew - name: Build with Gradle From 5f1c38752af7902e07b81688e444a59c5a129f14 Mon Sep 17 00:00:00 2001 From: Andreas Schmid Date: Sun, 9 Feb 2020 11:09:11 +0100 Subject: [PATCH 3/8] matrix build on different java versions --- .github/workflows/gradle.yml | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml index f9412d0..5c89bec 100644 --- a/.github/workflows/gradle.yml +++ b/.github/workflows/gradle.yml @@ -1,19 +1,23 @@ name: Java CI -on: [push] +on: [push, pull_request] jobs: build: - - runs-on: ubuntu-latest + name: Build on ${{ matrix.os }} and JDK ${{ matrix.java_version }} + runs-on: ${{ matrix.os }} + strategy: + matrix: + java_version: [8, 9, 10, 11, 12, 13] + os: [ubuntu-latest, windows-latest] steps: - uses: actions/checkout@v2 - - name: Set up JDK 1.8 + + - name: Set up JDK ${{ matrix.java_version }} uses: actions/setup-java@v1 with: - java-version: 1.8 - - name: Grant execute permission for gradlew - run: chmod +x gradlew + java-version: ${{ matrix.java_version }} + - name: Build with Gradle run: ./gradlew build From 9d2aae123a55d78b84cc63b31c2e0e38c695846b Mon Sep 17 00:00:00 2001 From: Andreas Schmid Date: Sun, 9 Feb 2020 11:17:03 +0100 Subject: [PATCH 4/8] docker container for integration tests --- .github/workflows/{gradle.yml => build.yml} | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) rename .github/workflows/{gradle.yml => build.yml} (67%) diff --git a/.github/workflows/gradle.yml b/.github/workflows/build.yml similarity index 67% rename from .github/workflows/gradle.yml rename to .github/workflows/build.yml index 5c89bec..40ea102 100644 --- a/.github/workflows/gradle.yml +++ b/.github/workflows/build.yml @@ -15,9 +15,15 @@ jobs: - uses: actions/checkout@v2 - name: Set up JDK ${{ matrix.java_version }} - uses: actions/setup-java@v1 + uses: actions/setup-java@v1.3 with: java-version: ${{ matrix.java_version }} + - name: Start taskd server + run: | + docker pull connectical/taskd + docker run -d --name=taskd -p 53589:53589 -v $(pwd)/docker/taskd:/var/taskd connectical/taskd + docker ps + - name: Build with Gradle run: ./gradlew build From 81fe4aa7c1a151172567e9cb983f36aa2fdd3f08 Mon Sep 17 00:00:00 2001 From: Andreas Schmid Date: Sun, 9 Feb 2020 11:18:28 +0100 Subject: [PATCH 5/8] fix java action version --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 40ea102..86fa3aa 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -15,7 +15,7 @@ jobs: - uses: actions/checkout@v2 - name: Set up JDK ${{ matrix.java_version }} - uses: actions/setup-java@v1.3 + uses: actions/setup-java@v1.3.0 with: java-version: ${{ matrix.java_version }} From 714b754eb467ae1d6b8530eaf96ce5dacd8eae5d Mon Sep 17 00:00:00 2001 From: Andreas Schmid Date: Sun, 9 Feb 2020 11:21:38 +0100 Subject: [PATCH 6/8] JDK 13 does not work with spotbugs currently --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 86fa3aa..d0eefbd 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -8,7 +8,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - java_version: [8, 9, 10, 11, 12, 13] + java_version: [8, 9, 10, 11, 12] os: [ubuntu-latest, windows-latest] steps: From 8eb1c2a22810538647fc109cd541fa61c64bae7f Mon Sep 17 00:00:00 2001 From: Andreas Schmid Date: Sun, 9 Feb 2020 11:39:35 +0100 Subject: [PATCH 7/8] build scans --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d0eefbd..569d2ea 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -26,4 +26,4 @@ jobs: docker ps - name: Build with Gradle - run: ./gradlew build + run: ./gradlew --scan build From a864d00fa1694304d3c769cc877969659b151147 Mon Sep 17 00:00:00 2001 From: Andreas Schmid Date: Sun, 9 Feb 2020 22:22:07 +0100 Subject: [PATCH 8/8] ugly try Signed-off-by: Andreas Schmid --- .../taskwarrior/client/TaskwarriorClient.java | 20 ++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/src/main/java/de/aaschmid/taskwarrior/client/TaskwarriorClient.java b/src/main/java/de/aaschmid/taskwarrior/client/TaskwarriorClient.java index f7469da..aabc0ca 100644 --- a/src/main/java/de/aaschmid/taskwarrior/client/TaskwarriorClient.java +++ b/src/main/java/de/aaschmid/taskwarrior/client/TaskwarriorClient.java @@ -4,7 +4,10 @@ import java.io.IOException; import java.io.InputStream; import java.io.OutputStream; +import java.net.InetAddress; +import java.net.InetSocketAddress; import java.net.Socket; +import java.util.Arrays; import de.aaschmid.taskwarrior.config.TaskwarriorConfiguration; import de.aaschmid.taskwarrior.message.TaskwarriorMessage; @@ -28,7 +31,22 @@ public TaskwarriorClient(TaskwarriorConfiguration config) { public TaskwarriorMessage sendAndReceive(TaskwarriorMessage message) { requireNonNull(message, "'message' must not be null."); - try (Socket socket = sslContext.getSocketFactory().createSocket(config.getServerHost(), config.getServerPort())) { + System.out.println(config.getServerHost()); + try { + System.out.println(InetSocketAddress.createUnresolved("localhost", config.getServerPort())); + System.out.println(Arrays.toString(InetAddress.getAllByName("localhost"))); + System.out.println(InetAddress.getLocalHost()); + System.out.println(InetAddress.getLoopbackAddress()); + System.out.println(InetAddress.getByName("localhost")); + } catch (IOException e) { + e.printStackTrace(); + } + try { + Socket socket = sslContext.getSocketFactory().createSocket(InetAddress.getLoopbackAddress(), config.getServerPort()); + } catch (IOException e) { + e.printStackTrace(); + } + try (Socket socket = sslContext.getSocketFactory().createSocket(InetAddress.getLoopbackAddress(), config.getServerPort())) { return sendAndReceive(socket, message); } catch (IOException e) { throw new TaskwarriorClientException(