Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: prometheus/client_python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
Loading
...
head repository: aadityadhruv/client_python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Loading
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Jun 26, 2025

  1. Add support to write_to_textfile for custom tmpdir

    While the try/except block does prevent most of the temp files from
    persisting, if there is a non catchable exception, those temp files
    continue to pollute the directory. Optionally set the temp
    directory would let us write to something like /tmp, so the target
    directory isn't polluted
    
    Signed-off-by: Aaditya Dhruv <aadityadhruv@mailbox.org>
    aadityadhruv committed Jun 26, 2025
    Configuration menu
    Copy the full SHA
    7da3eee View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2025

  1. Modify write_to_textfile to ensure tmpdir is on same filesystem

    The tmpdir must be on the same filesystem to ensure an atomic operation
    takes place. If this is not enforced, there could be partial writes
    which can lead to partial/incorrect metrics being exported
    
    Signed-off-by: Aaditya Dhruv <aadityadhruv@mailbox.org>
    aadityadhruv committed Jul 10, 2025
    Configuration menu
    Copy the full SHA
    4804d35 View commit details
    Browse the repository at this point in the history
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.