fix: Add no-arg overload for getUserInput() in RequestContext to avoid#673
fix: Add no-arg overload for getUserInput() in RequestContext to avoid#673ehsavoie wants to merge 1 commit intoa2aproject:maina2aproject/a2a-java:mainfrom
Conversation
Summary of ChangesHello @ehsavoie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a convenient no-argument overload for getUserInput() to default to a newline delimiter. The changes are good, but I've found a critical bug where a NullPointerException can occur, and a minor issue in the Javadoc for the new method. Please see my comments for details.
| delimiter = "\n"; | ||
| delim = "\n"; | ||
| } | ||
| return getMessageText(params.message(), delimiter); |
There was a problem hiding this comment.
The local variable delim is correctly initialized with a default value if delimiter is null, but the original delimiter is then passed to getMessageText. This will cause a NullPointerException if getUserInput(null) is called, because String.join (used inside getMessageText) does not accept a null delimiter. The delim variable should be used in the method call instead.
| return getMessageText(params.message(), delimiter); | |
| return getMessageText(params.message(), delim); |
| * <b>Examples:</b> | ||
| * <pre>{@code | ||
| * // Join with newlines (common for multi-paragraph input) | ||
| * String text = context.getUserInput("\n"); |
There was a problem hiding this comment.
The Javadoc example for the new getUserInput() method is incorrect. It shows a call to getUserInput("\n"), which is the method it's meant to simplify. The example should demonstrate the use of the no-argument overload.
| * String text = context.getUserInput("\n"); | |
| * String text = context.getUserInput(); |
passing null for default delimiter. Fixes issue a2aproject#668 Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
| delim = "\n"; | ||
| } | ||
| return getMessageText(params.message(), delimiter); | ||
| return getMessageText(params.message(), delim); |
There was a problem hiding this comment.
Small suggestion. How about using a ternary operator here? It might make the code simpler.
return getMessageText(params.message(), (delimiter == null) ? "\n" : delimiter);
passing null for default delimiter.
Fixes issue #668
Fixes #668 🦕