Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

fix: flaky testInputRequiredWorkflow test#671

Merged
kabir merged 1 commit intoa2aproject:maina2aproject/a2a-java:mainfrom
kabir:flaky_testkabir/a2a-java:flaky_testCopy head branch name to clipboard
Feb 18, 2026
Merged

fix: flaky testInputRequiredWorkflow test#671
kabir merged 1 commit intoa2aproject:maina2aproject/a2a-java:mainfrom
kabir:flaky_testkabir/a2a-java:flaky_testCopy head branch name to clipboard

Conversation

@kabir
Copy link
Collaborator

@kabir kabir commented Feb 18, 2026

No description provided.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 18, 2026

Summary of Changes

Hello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a flaky test by refining the task state transition logic within the AgentExecutorProducer and enhancing the test's cleanup mechanism. The changes prevent race conditions that could lead to inconsistent test outcomes and ensure that resources are only cleaned up if they were successfully initialized, improving the overall reliability of the test suite.

Highlights

  • Flaky Test Fix: Addressed flakiness in the testInputRequiredWorkflow by preventing race conditions during task state transitions and ensuring robust test cleanup.
  • Race Condition Mitigation: Modified AgentExecutorProducer to directly transition tasks to INPUT_REQUIRED or COMPLETED states, bypassing the WORKING state to avoid interruptions and potential race conditions.
  • Robust Test Cleanup: Implemented conditional task deletion in AbstractA2AServerTest to ensure deleteTaskInTaskStore is only called if the task was successfully created, preventing errors during test cleanup.
Changelog
  • tests/server-common/src/test/java/io/a2a/server/apps/common/AbstractA2AServerTest.java
    • Introduced a taskCreated boolean flag to track successful task initialization.
    • Modified the finally block to conditionally delete the task based on the taskCreated flag, preventing deletion of non-existent tasks.
  • tests/server-common/src/test/java/io/a2a/server/apps/common/AgentExecutorProducer.java
    • Removed the agentEmitter.startWork() call before agentEmitter.requiresInput() to directly transition to INPUT_REQUIRED.
    • Removed the agentEmitter.startWork() call before agentEmitter.complete() to directly transition to COMPLETED.
    • Added comments explaining the rationale for skipping the WORKING state to avoid race conditions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 18, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses a flaky test, testInputRequiredWorkflow, with two well-reasoned changes. The test cleanup is made more robust by conditionally deleting the test task only if it was successfully created, which prevents cleanup failures from obscuring the root cause of a test failure. Additionally, the test's agent logic is updated to skip an intermediate WORKING state, a change that aims to prevent a race condition and improve stability. The modifications are logical and well-contained.

@kabir kabir merged commit e8fd7f2 into a2aproject:main Feb 18, 2026
11 checks passed
@kabir kabir deleted the flaky_test branch February 18, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kabir
Morty Proxy This is a proxified and sanitized view of the page, visit original site.