chore: add workaround for container tests#659
chore: add workaround for container tests#659kabir merged 1 commit intoa2aproject:maina2aproject/a2a-java:mainfrom jmesnil:multi-instance_docker_testjmesnil/a2a-java:multi-instance_docker_testCopy head branch name to clipboard
Conversation
Summary of ChangesHello @jmesnil, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a critical workaround to address a specific issue encountered with Testcontainers during containerized test execution. By configuring a system property in the Maven build, it ensures the stability and proper functioning of these tests, allowing development to proceed without hindrance from the external dependency problem. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a workaround for a Testcontainers issue by setting the api.version system property. The change is well-commented with a link to the upstream issue, which is helpful for future maintenance. My review includes a suggestion to extract the hardcoded version into a Maven property to improve the project's maintainability.
| <systemPropertyVariables> | ||
| <java.util.logging.manager>org.jboss.logmanager.LogManager</java.util.logging.manager> | ||
| <!-- workaround for https://github.com/testcontainers/testcontainers-java/issues/11212 --> | ||
| <api.version>1.44</api.version> |
There was a problem hiding this comment.
To improve maintainability and avoid a magic number, consider defining this version in a <properties> section at the top of this pom.xml and referencing it with a property. This makes it clearer what the value represents and easier to update.
For example, you could add this block to your pom.xml (e.g., after the <name> element):
<properties>
<!-- Workaround for https://github.com/testcontainers/testcontainers-java/issues/11212 -->
<docker.api.version.workaround>1.44</docker.api.version.workaround>
</properties>Then, you can apply the suggested change below.
| <api.version>1.44</api.version> | |
| <api.version>${docker.api.version.workaround}</api.version> |
There was a problem hiding this comment.
@gemini-code-assist. Let's not do that. This is a temporary workaround and this version is not meant to be maintained once the testcontainers dependency is updated and the workaround not required anymore
There was a problem hiding this comment.
Understood. Your reasoning regarding the temporary nature of the workaround makes sense. In this context, avoiding the overhead of defining a property for a short-lived value is a reasonable approach. Thank you for the clarification.
For the docker api.version to 1.44 to workaround testcontainers/testcontainers-java#11212 Signed-off-by: Jeff Mesnil <jmesnil@ibm.com>
a31e07b to
cafb087
Compare
This reverts commit 14e5eeb.
This reverts commit 14e5eeb.
This reverts commit 14e5eeb.
No description provided.