fix: ListTask's statusTimestampAfter only accept ISO 8601 format#640
fix: ListTask's statusTimestampAfter only accept ISO 8601 format#640jmesnil merged 1 commit intoa2aproject:maina2aproject/a2a-java:mainfrom jmesnil:639_statusTimestampAfter_ISO-8601jmesnil/a2a-java:639_statusTimestampAfter_ISO-8601Copy head branch name to clipboard
Conversation
Summary of ChangesHello @jmesnil, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the handling of timestamp parameters within the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly enforces that the statusTimestampAfter parameter for ListTasks only accepts the ISO 8601 format, removing the previous support for Unix timestamps. The change is implemented for both the REST and gRPC-JSON transports, with corresponding test updates to validate the new behavior. The implementation is solid, and the minor suggestion to improve a user-facing error message remains valid.
transport/rest/src/main/java/io/a2a/transport/rest/handler/RestHandler.java
Outdated
Show resolved
Hide resolved
This fixes a2aproject#639 Signed-off-by: Jeff Mesnil <jmesnil@ibm.com>
32fea5c to
a2e89f8
Compare
Fixes #639 🦕