chore: Upgrade Nullaway and error prone#629
chore: Upgrade Nullaway and error prone#629ehsavoie merged 1 commit intoa2aproject:maina2aproject/a2a-java:mainfrom
Conversation
Upgrading Nullaway fro 0.12.14 to 0.13.1: uber/NullAway@v0.12.14...v0.13.1 Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Summary of ChangesHello @ehsavoie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the versions of NullAway and Error Prone in the project's dependencies. These upgrades likely include bug fixes, performance improvements, and new features from the updated tools, contributing to overall code quality and static analysis capabilities. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request upgrades the error-prone and nullaway dependencies. The change is straightforward, but I've identified a potential issue with an incomplete update. The versions for these dependencies are also specified in the old_jdk_support profile but were not updated. My review includes a comment to address this for consistency across different JDK environments.
| <error-prone.version>2.47.0</error-prone.version> | ||
| <nullaway.version>0.13.1</nullaway.version> |
There was a problem hiding this comment.
This dependency upgrade appears to be incomplete. The error-prone.version and nullaway.version properties are also defined in the old_jdk_support profile (lines 575-576) but have not been updated. To ensure consistent behavior and tooling across all supported JDK environments, please update these versions in the profile as well. If these dependencies must remain pinned to older versions for specific JDKs, please add a comment explaining the compatibility constraints.
Upgrading Nullaway fro 0.12.14 to 0.13.1:
uber/NullAway@v0.12.14...v0.13.1