Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: InMemoryPushNotificationConfigStore uses wrong pagination token.#555

Merged
kabir merged 1 commit intoa2aproject:maina2aproject/a2a-java:mainfrom
ehsavoie:fix_554ehsavoie/a2a-java:fix_554Copy head branch name to clipboard
Dec 19, 2025
Merged

fix: InMemoryPushNotificationConfigStore uses wrong pagination token.#555
kabir merged 1 commit intoa2aproject:maina2aproject/a2a-java:mainfrom
ehsavoie:fix_554ehsavoie/a2a-java:fix_554Copy head branch name to clipboard

Conversation

@ehsavoie
Copy link
Collaborator

@ehsavoie ehsavoie commented Dec 19, 2025

  • Using the 'id' field instead of the 'token' field as the pagination token.

Fixes #554

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests pass
  • Appropriate READMEs were updated (if necessary)

Fixes #554 🦕

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 19, 2025

Summary of Changes

Hello @ehsavoie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug within the InMemoryPushNotificationConfigStore where the pagination logic was incorrectly referencing the token field instead of the id field. By switching to the correct id field, this change ensures that subsequent pages of push notification configurations are retrieved accurately, thereby stabilizing the pagination functionality for this component.

Highlights

  • Pagination Token Fix: Corrected the InMemoryPushNotificationConfigStore to use the id field instead of the token field for generating and comparing pagination tokens, resolving an issue where pagination was not functioning as intended.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 19, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a bug in the pagination logic for InMemoryPushNotificationConfigStore by using the configuration's id field for the pagination token instead of the authentication token field. The change is consistent across token generation and consumption, and it aligns with the semantic purpose of the fields. My review includes a suggestion to improve the clarity and maintainability of the findFirstIndex method.

server-common/src/main/java/io/a2a/server/tasks/InMemoryPushNotificationConfigStore.java Outdated Show resolved Hide resolved
@ehsavoie
fix: InMemoryPushNotificationConfigStore uses wrong pagination token.
adbccee 
* Using the 'id' field instead of the 'token' field as the pagination
  token.

Fixes a2aproject#554

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
@kabir kabir merged commit a2daec9 into a2aproject:main Dec 19, 2025
11 checks passed
kabir pushed a commit to kabir/a2a-java that referenced this pull request Dec 23, 2025
@ehsavoie @kabir
fix: InMemoryPushNotificationConfigStore uses wrong pagination token. (…
a30c4e6 
…a2aproject#555)

* Using the 'id' field instead of the 'token' field as the pagination
token.

Fixes a2aproject#554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: InMemoryPushNotificationConfigStore uses wrong pagination token

2 participants

@ehsavoie @kabir

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.