Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

feat: Add Javadoc for the spec module#466

Merged
kabir merged 2 commits intoa2aproject:maina2aproject/a2a-java:mainfrom
kabir:javadockabir/a2a-java:javadocCopy head branch name to clipboard
Nov 21, 2025
Merged

feat: Add Javadoc for the spec module#466
kabir merged 2 commits intoa2aproject:maina2aproject/a2a-java:mainfrom
kabir:javadockabir/a2a-java:javadocCopy head branch name to clipboard

Conversation

@kabir
Copy link
Collaborator

@kabir kabir commented Nov 19, 2025 •
edited
Loading

Fixes: #475

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 19, 2025

Summary of Changes

Hello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the clarity and maintainability of the codebase through comprehensive Javadoc documentation for the AgentCard class, which is central to agent discovery in the A2A Protocol. Concurrently, it addresses minor technical debt by removing superfluous imports and standardizing code formatting across various Java files, contributing to a cleaner and more consistent project structure.

Highlights

  • Javadoc Documentation Enhancement: Significantly improved the Javadoc documentation for the AgentCard record and its nested Builder class, providing detailed explanations for each parameter, the class's purpose, and usage examples. This enhancement clarifies the contract and usage of AgentCards within the A2A Protocol.
  • Code Cleanup and Formatting: Performed extensive code cleanup across multiple modules, primarily focusing on removing unused import statements and applying minor formatting adjustments to improve code readability and maintain consistency. This includes reformatting multi-line method calls and lambda expressions in ProtoUtils.java and adjusting @Route annotations in A2ATestRoutes.java.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@kabir kabir changed the title Javadoc fix: Javadoc (WIP) Nov 19, 2025
@kabir kabir marked this pull request as draft November 19, 2025 16:24
gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 19, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces extensive Javadoc documentation, particularly in AgentCard.java, which significantly improves code clarity. It also includes widespread code cleanup by removing unused imports and applying consistent formatting. One notable improvement is making DEFAULT_PROTOCOL_VERSION public in AgentCard. However, the reformatting in TaskManagerTest.java has led to excessive indentation that harms readability and should be corrected. Other formatting changes in ProtoUtils.java could also be improved for better adherence to standard Java stream formatting conventions.

fjuma
fjuma approved these changes Nov 19, 2025
View reviewed changes
Copy link
Collaborator

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kabir kabir changed the title fix: Javadoc (WIP) feat: Add Javadoc for the spec module Nov 21, 2025
@kabir kabir marked this pull request as ready for review November 21, 2025 11:01
@kabir
Copy link
Collaborator Author

kabir commented Nov 21, 2025

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 21, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces comprehensive Javadoc documentation across the entire spec module. The added comments are clear, detailed, and significantly improve the readability and maintainability of the codebase. This is an excellent contribution to the project's quality. I have one minor suggestion to further improve the consistency of the new documentation.

spec/src/main/java/io/a2a/spec/A2AClientError.java Show resolved Hide resolved
@kabir kabir merged commit 7dd1f59 into a2aproject:main Nov 21, 2025
11 checks passed
@jmesnil jmesnil added this to the 1.0.0 milestone Dec 11, 2025
kabir added a commit to kabir/a2a-java that referenced this pull request Dec 23, 2025
@kabir
feat: Add Javadoc for the spec module (a2aproject#466)
d0fa522 
Fixes: a2aproject#475
@kabir kabir deleted the javadoc branch December 23, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjuma fjuma fjuma approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

[Feat]: Create Javadoc for the spec module

3 participants

@kabir @fjuma @jmesnil
Morty Proxy This is a proxified and sanitized view of the page, visit original site.