From c17a4d4eb0ba41e0776f86953829b4750a72b1f1 Mon Sep 17 00:00:00 2001 From: Emmanuel Hugonnet Date: Wed, 5 Nov 2025 11:21:22 +0100 Subject: [PATCH] fix: NPE with test JSONRPCHandlerTest.testOnMessageNewMessageSuccessMocks (#444) Simple fix for JSONRPCHandlerTest.testOnMessageNewMessageSuccessMocks ensuring that the DoneCallback is not null when mocking. Signed-off-by: Emmanuel Hugonnet --- .../src/main/java/io/a2a/server/events/EnhancedRunnable.java | 1 - .../io/a2a/transport/jsonrpc/handler/JSONRPCHandlerTest.java | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server-common/src/main/java/io/a2a/server/events/EnhancedRunnable.java b/server-common/src/main/java/io/a2a/server/events/EnhancedRunnable.java index 17d5b3e9a..380cb04f4 100644 --- a/server-common/src/main/java/io/a2a/server/events/EnhancedRunnable.java +++ b/server-common/src/main/java/io/a2a/server/events/EnhancedRunnable.java @@ -1,6 +1,5 @@ package io.a2a.server.events; -import java.util.ArrayList; import java.util.List; import java.util.concurrent.CopyOnWriteArrayList; diff --git a/transport/jsonrpc/src/test/java/io/a2a/transport/jsonrpc/handler/JSONRPCHandlerTest.java b/transport/jsonrpc/src/test/java/io/a2a/transport/jsonrpc/handler/JSONRPCHandlerTest.java index c2cf1f751..450c0e76d 100644 --- a/transport/jsonrpc/src/test/java/io/a2a/transport/jsonrpc/handler/JSONRPCHandlerTest.java +++ b/transport/jsonrpc/src/test/java/io/a2a/transport/jsonrpc/handler/JSONRPCHandlerTest.java @@ -186,7 +186,8 @@ public void testOnMessageNewMessageSuccessMocks() { SendMessageResponse response; try (MockedConstruction mocked = Mockito.mockConstruction( EventConsumer.class, - (mock, context) -> {Mockito.doReturn(ZeroPublisher.fromItems(wrapEvent(MINIMAL_TASK))).when(mock).consumeAll();})){ + (mock, context) -> {Mockito.doReturn(ZeroPublisher.fromItems(wrapEvent(MINIMAL_TASK))).when(mock).consumeAll(); + Mockito.doCallRealMethod().when(mock).createAgentRunnableDoneCallback();})){ response = handler.onMessageSend(request, callContext); } assertNull(response.getError());