fix: Make sure we use @Inject on @ConfigProperty#437
fix: Make sure we use @Inject on @ConfigProperty#437kabir merged 1 commit intoa2aproject:maina2aproject/a2a-java:mainfrom kabir:inject-config-propertieskabir/a2a-java:inject-config-propertiesCopy head branch name to clipboard
Conversation
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where configuration properties annotated with Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly adds the @Inject annotation to fields that use @ConfigProperty, which is necessary for dependency injection in Jakarta EE environments. The changes are correct and resolve the issue. I've added a couple of suggestions to improve encapsulation by making the injected fields private, which is a common best practice in CDI.
...ples/cloud-deployment/server/src/main/java/io/a2a/examples/cloud/CloudAgentCardProducer.java
Show resolved
Hide resolved
...re-database-jpa/src/main/java/io/a2a/extras/taskstore/database/jpa/JpaDatabaseTaskStore.java
Show resolved
Hide resolved
Jakarta needs this or it ignores the config
6160890 to
8e6a13e
Compare
Jakarta needs this or it ignores the config Upstream: #437
Jakarta needs this or it ignores the config
Jakarta needs this or it ignores the config