Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

fix: Changes needed to have ConfigProperty injection working in Jakarta#418

Merged
kabir merged 1 commit intoa2aproject:0.3.xa2aproject/a2a-java:0.3.xfrom
kabir:jakarta-fixes-0.3.xkabir/a2a-java:jakarta-fixes-0.3.xCopy head branch name to clipboard
Oct 30, 2025
Merged

fix: Changes needed to have ConfigProperty injection working in Jakarta#418
kabir merged 1 commit intoa2aproject:0.3.xa2aproject/a2a-java:0.3.xfrom
kabir:jakarta-fixes-0.3.xkabir/a2a-java:jakarta-fixes-0.3.xCopy head branch name to clipboard

Conversation

@kabir
Copy link
Collaborator

@kabir kabir commented Oct 30, 2025

Upstream: #417

@kabir kabir added the 0.3.x label Oct 30, 2025
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Oct 30, 2025

Summary of Changes

Hello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where ConfigProperty values were not being correctly injected in standard Jakarta EE environments. By explicitly annotating these configuration properties with @Inject, the change ensures that dependency injection mechanisms correctly provide the configured values, enhancing the application's compatibility and reliability across different Jakarta EE runtimes.

Highlights

  • Jakarta ConfigProperty Injection: Enabled proper injection of @ConfigProperty annotated fields by adding the @Inject annotation. This change specifically targets standard Jakarta runtimes, as some frameworks like Quarkus might handle this implicitly.
  • Type Refinement: The keepAliveSeconds property's type was updated from long to int.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 30, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the @Inject annotation to @ConfigProperty fields to ensure proper dependency injection in standard Jakarta runtimes, which is a good fix for portability. I have one suggestion to revert the type of keepAliveSeconds from int back to long to better align with the ThreadPoolExecutor API it's used with. Otherwise, the changes look good.

server-common/src/main/java/io/a2a/server/util/async/AsyncExecutorProducer.java Outdated Show resolved Hide resolved
@kabir kabir force-pushed the jakarta-fixes-0.3.x branch from a6432ec to ee9887a Compare October 30, 2025 17:44
@kabir kabir merged commit db1e266 into a2aproject:0.3.x Oct 30, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

0.3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kabir
Morty Proxy This is a proxified and sanitized view of the page, visit original site.