Revert "test: add ToProto and FromProto tests"#381
Revert "test: add ToProto and FromProto tests"#381ehsavoie merged 1 commit intomaina2aproject/a2a-java:mainfrom revert-341-add-protoutil-testsa2aproject/a2a-java:revert-341-add-protoutil-testsCopy head branch name to clipboard
Conversation
This reverts commit 4ddac8b.
Summary of ChangesHello @ehsavoie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request serves to undo a previous set of changes that introduced new test cases for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change, removing tests for ToProto and FromProto utility methods. While the original tests may have had issues, completely removing them is not ideal as it reduces test coverage for ProtoUtils, increasing the risk of future regressions. It would be preferable to fix the tests or replace them to ensure the utility methods are behaving as expected, especially around edge cases like handling unsupported types or malformed inputs.
Reverts #341