ci: add Java version matrix (17, 21, 24) to run-tck workflow#323
Merged
kabir merged 3 commits intoa2aproject:maina2aproject/a2a-java:mainfrom Oct 2, 2025
whatsupsumit:issue-314-tck-matrixwhatsupsumit/a2a-java:issue-314-tck-matrixCopy head branch name to clipboard
Merged
ci: add Java version matrix (17, 21, 24) to run-tck workflow#323kabir merged 3 commits intoa2aproject:maina2aproject/a2a-java:mainfrom whatsupsumit:issue-314-tck-matrixwhatsupsumit/a2a-java:issue-314-tck-matrixCopy head branch name to clipboard
kabir merged 3 commits intoa2aproject:maina2aproject/a2a-java:mainfrom
whatsupsumit:issue-314-tck-matrixwhatsupsumit/a2a-java:issue-314-tck-matrixCopy head branch name to clipboard
Conversation
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
- Updated run-tck.yml to use a matrix strategy - Tests will now run against Java versions 17, 21, and 24 - Fixes a2aproject#314
b2304c6 to
4bbfa68
Compare
Collaborator
|
Shouldn't we use 25 instead of 24 now that 25 is GA ? |
Collaborator
|
@whatsupsumit Thanks! It seem @ehsavoie is right, my bad. It seems that 25, NOT 24, is the LTS release. Would you be able to replace 24 with 25? Sorry for the inconvenience |
Contributor
Author
|
Sure ...I can do that |
- Updated Java matrix to use version 25 instead of 24 (now GA) - Upgraded actions/setup-java from v4 to v5 - Tests will run against Java 17, 21, and 25
Contributor
Author
|
gotcha ! I made the changes...🫡 |
- Added profile to exclude KafkaReplicationIntegrationTest on Java 24+ - Follows existing pattern from push-notification-config-store-database-jpa - Addresses Vert.x 4.5.x incompatibility with Java 24+ in Quarkus 3.28.x - Tests will skip problematic integration tests on Java 25 while keeping unit tests
Collaborator
|
@whatsupsumit Thank you. I know I did the KafkaReplicationIntegrationTest exclusion the other day, and am quite sure I committed it. So I was surprised to see it added here, but looking in the main branch I don't see it there. So that is strange, but thank you for picking up on that :-) |
kabir
pushed a commit
to kabir/a2a-java
that referenced
this pull request
Dec 23, 2025
…ect#323) - Updated run-tck.yml to use a matrix strategy - Tests will now run against Java versions 17, 21, and 24 - Fixes a2aproject#314 <img width="1438" height="978" alt="Screenshot 2025-10-01 232520" src="https://github.com/user-attachments/assets/9b05e006-5d6f-4c79-b6fe-d3b3ae571bc4" /> # Description Added a matrix strategy to the tck-test job with Java versions: [17, 21, 24] Updated the JDK setup step to use ${{ matrix.java-version }} instead of hardcoded '17' Updated the step name to dynamically show which Java version is being used Fixes #<314> 🦕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a matrix strategy to the tck-test job with Java versions: [17, 21, 24]
Updated the JDK setup step to use ${{ matrix.java-version }} instead of hardcoded '17'
Updated the step name to dynamically show which Java version is being used
Fixes #<314> 🦕