chore: upgrade build-and-test workflow to test Java 17 and 21#321
chore: upgrade build-and-test workflow to test Java 17 and 21#321kabir merged 5 commits intoa2aproject:maina2aproject/a2a-java:mainfrom
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
fjuma
left a comment
There was a problem hiding this comment.
Thanks very much @Asymtode712!
|
Thanks @Asymtode712! It looks good and passes CI. However, I messed up in the original issue and put 24 which should have been 25, which is the actual LTS version. Would you be able to update it? |
|
@kabir sure !! |
|
@kabir done with the changes, kindly review |
|
Sorry, @Asymtode712 it doesn't seem to me my day :-D We actually need to leave 25 out since we don't have a Quarkus/Vert.X version yet that supports Java 25. We're tracking that here #315. That explains the test failures. Would you be able to remove 25 from the matrix? |
|
@kabir sure np |
Removed Java version '25' from the build matrix.
|
@kabir done with the change, please review |
|
Thank you @Asymtode712 ! |
…ject#321) # Description - Added matrix strategy to test against multiple Java versions (17, 21) - Dynamically sets JDK version in workflow steps using matrix variable - Ensures compatibility across different Java environments <img width="612" height="355" alt="image" src="https://github.com/user-attachments/assets/67345f39-87b6-472f-b144-d6480759628f" /> Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [X] Follow the [`CONTRIBUTING` Guide](../CONTRIBUTING.md). - [X] Make your Pull Request title in the <https://www.conventionalcommits.org/> specification. - [X] Ensure the tests pass Fixes a2aproject#313 🦕
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.Fixes #313 🦕