[Feat]: Revisit exception handling in DefaultRequestHandler.onMessageSend()

Is your feature request related to a problem? Please describe.

No response

Describe the solution you'd like

In DefaultRequestHandler

a2a-java/server-common/src/main/java/io/a2a/server/requesthandlers/DefaultRequestHandler.java

Lines 289 to 301 in da7ee20

    
           } catch (InterruptedException e) { 
        
               Thread.currentThread().interrupt(); 
        
               String msg = String.format("Error waiting for task %s completion", taskId); 
        
               LOGGER.warn(msg, e); 
        
               throw new InternalError(msg); 
        
           } catch (java.util.concurrent.ExecutionException e) { 
        
               String msg = String.format("Error during task %s execution", taskId); 
        
               LOGGER.warn(msg, e.getCause()); 
        
               throw new InternalError(msg); 
        
           } catch (java.util.concurrent.TimeoutException e) { 
        
               String msg = String.format("Timeout waiting for consumption to complete for task %s", taskId); 
        
               LOGGER.warn(msg, taskId); 
        
               throw new InternalError(msg);

we currently throw InternalError if InterruptedException, TimeoutException or ExecutionException happens.

We were originally just logging the errors, and passed review on main. But then on the 0.3.x backport PR, Gemini had a comment, which led us to adding these errors. However, this doesn't feel very correct.

We need to investigate these cases:

TimeoutException - this probably just means that the client timed out, and that the processing of the Task should happen in the background
ExecutionException - Possibly, this will be tracked by the handling in DefaultRequestHandler.registerAndExecuteAgentAsync()?
InterruptedException - I think this means the sever is shutting down. What does this mean for the Task?

Another thing to note is that with the current aggressive throwing of InternalError in all three cases, we won't invoke PushNotification callbacks

Describe alternatives you've considered

No response

Additional context

No response

Code of Conduct

I agree to follow this project's Code of Conduct

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feat]: Revisit exception handling in DefaultRequestHandler.onMessageSend() #449

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Code of Conduct

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	} catch (InterruptedException e) {
	Thread.currentThread().interrupt();
	String msg = String.format("Error waiting for task %s completion", taskId);
	LOGGER.warn(msg, e);
	throw new InternalError(msg);
	} catch (java.util.concurrent.ExecutionException e) {
	String msg = String.format("Error during task %s execution", taskId);
	LOGGER.warn(msg, e.getCause());
	throw new InternalError(msg);
	} catch (java.util.concurrent.TimeoutException e) {
	String msg = String.format("Timeout waiting for consumption to complete for task %s", taskId);
	LOGGER.warn(msg, taskId);
	throw new InternalError(msg);

Search code, repositories, users, issues, pull requests...

[Feat]: Revisit exception handling in DefaultRequestHandler.onMessageSend() #449

Description

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Code of Conduct

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions