fix(core): allow zero max size caches across providers#173
Merged
iProdigy merged 2 commits intomainXanthic/cache-api:mainfrom Sep 24, 2023
fix/cache-zero-max-size-timeXanthic/cache-api:fix/cache-zero-max-size-timeCopy head branch name to clipboard
Merged
fix(core): allow zero max size caches across providers#173iProdigy merged 2 commits intomainXanthic/cache-api:mainfrom fix/cache-zero-max-size-timeXanthic/cache-api:fix/cache-zero-max-size-timeCopy head branch name to clipboard
iProdigy merged 2 commits intomainXanthic/cache-api:mainfrom
fix/cache-zero-max-size-timeXanthic/cache-api:fix/cache-zero-max-size-timeCopy head branch name to clipboard
Conversation
Member
Author
|
Open question: Users may assume Edit: actually this behavior could be interpreted as performing a write & immediately evicting it, so I will proceed with the patch |
iProdigy
commented
Sep 24, 2023
core/src/main/java/io/github/xanthic/cache/core/delegate/EmptyCache.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/github/xanthic/cache/core/delegate/EmptyCache.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/github/xanthic/cache/core/delegate/EmptyCache.java
Outdated
Show resolved
Hide resolved
Signed-off-by: iProdigy <8106344+iProdigy@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
PhilippHeuer
approved these changes
Sep 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users may do
maxSize(0L)orexpiryTime(Duration.ZERO)to "disable" caching.However, this is not supported by all of the underlying providers: https://togithub.com/FasterXML/jackson-databind/pull/4115#discussion_r1335062530
This PR returns
EmptyCache.INSTANCEin these scenarios to avoid exceptions/inconsistency across providers.