Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 5416257

Browse filesBrowse files
rickeylevrickeylev
authored
test: Remove testonly=True from test toolchain implementations (bazel-contrib#1327)
Upcoming Bazel versions enforce testonly-ness through toolchain lookup, so when `:current_py_cc_headers` depends on (via toolchain lookup) a `py_cc_toolchain(testonly=True)` target, an error occurs. To fix, just remove testonly=True from the toolchain implementation. Fixes bazel-contrib#1324
1 parent 49d2b7a commit 5416257
Copy full SHA for 5416257

File tree

1 file changed

+0
-2
lines changed
Filter options

1 file changed

+0
-2
lines changed

‎tests/cc/BUILD.bazel

Copy file name to clipboardExpand all lines: tests/cc/BUILD.bazel
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ toolchain(
2828

2929
py_cc_toolchain(
3030
name = "fake_py_cc_toolchain_impl",
31-
testonly = True,
3231
headers = ":fake_headers",
3332
python_version = "3.999",
3433
tags = PREVENT_IMPLICIT_BUILDING_TAGS,
@@ -37,7 +36,6 @@ py_cc_toolchain(
3736
# buildifier: disable=native-cc
3837
cc_library(
3938
name = "fake_headers",
40-
testonly = True,
4139
hdrs = ["fake_header.h"],
4240
data = ["data.txt"],
4341
includes = ["fake_include"],

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.