Do not load external bootstrap resources for cdn_resources = 'in_line' | 'local'#201
Open
FieteO wants to merge 4 commits intoWestHealth:masterWestHealth/pyvis:masterfrom
FieteO:do-not-load-external-resources-for-in-lineFieteO/pyvis:do-not-load-external-resources-for-in-lineCopy head branch name to clipboard
Open
Do not load external bootstrap resources for cdn_resources = 'in_line' | 'local'#201FieteO wants to merge 4 commits intoWestHealth:masterWestHealth/pyvis:masterfrom FieteO:do-not-load-external-resources-for-in-lineFieteO/pyvis:do-not-load-external-resources-for-in-lineCopy head branch name to clipboard
FieteO wants to merge 4 commits intoWestHealth:masterWestHealth/pyvis:masterfrom
FieteO:do-not-load-external-resources-for-in-lineFieteO/pyvis:do-not-load-external-resources-for-in-lineCopy head branch name to clipboard
Conversation
Member
BerserkerGaruk
left a comment
There was a problem hiding this comment.
Went through the commit, I agree with the changes made, but I'm going to need to verify the hash between the bootstrap and visj min.js and .min.css files on my side before merging.
Author
|
Do you need anything from my side for validating the checksums? @BerserkerGaruk |
f8736bc to
19b8f78
Compare
Author
|
@BerserkerGaruk @summerswallow-whi , I have rebased the branch to resolve the merge conflicts that occurred in the meantime. I would appreciate it, if you could take a look, since the MR is open for a couple of month now |
|
Is there anything that could be done to help with this? |
|
I had verified e2e this change on my offline code with cc @summerswallow-whi @BerserkerGaruk Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cdn_resourcesoption should control how external resources and stylesheets should be loaded.Currently bootstrap is being fetched from CDN irrespective of the
cdn_resourcesoption.Also I have observed some inconsistencies in the
localoption where thevis-networkcss and js files are not being taken from thelibfolder but rather externally fetched. Please correct me here if my understanding of how these options are intended to work is wrong.To summarise the changes:
cdn_resources = 'remote'lib/whencdn_resources = 'local'example.ipynbto update the samples