This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Fixed the directory upload test#477
Open
phistuck wants to merge 1 commit intoWebPlatformTest:version-8.0WebPlatformTest/HTML5test:version-8.0from
Open
Fixed the directory upload test#477phistuck wants to merge 1 commit intoWebPlatformTest:version-8.0WebPlatformTest/HTML5test:version-8.0from
phistuck wants to merge 1 commit intoWebPlatformTest:version-8.0WebPlatformTest/HTML5test:version-8.0from
Conversation
Included a prefixed version.
Collaborator
|
The And you are right regarding the So, the test should be fixed, but |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included a prefixed version.
I cannot find any specification that defined
HTMLInputElement.prototype.directory(perhaps an old version of https://wicg.github.io/directory-upload/proposal.html - no idea) and Chrome does support a prefixed version of that (webkitDirectory) anyway, however, it does not support window.Directory (or any prefixed equivalent), so I think it is fine to use that for now instead of relying on a specification that is changing as we speak.It makes sense to me to just put it in a bonus points section. Also, a link to the specification is missing.