Changed to work without ColorAxis. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SADASHIMA
commented
Oct 3, 2024
- Add Fill in PolygonSeries class
- polyColor works as follows
- If Fill Is Undefined
- If Is ColorAxis valid
- Get color from ColorAxis
- Else
- Get Default Color
- If Is ColorAxis valid
- Else
- If Fill Is Automatic
- Get Default Color
- Else
- Fill
- If Fill Is Automatic
- If Fill Is Undefined
- Added an example without ColorAixs
Author
|
If the usage is the same when using ColorAxis and Value and when using Fill, I think the Fill should be defined in PolygonItem. |
Owner
|
Yes, I'd be in favour of allowing full control of the presentation in the individual items Thanks for working on this, I'll try to review your PR properly over the weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.