Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

自動リリースworkflowを追加#3

Open
y-chan wants to merge 10 commits intoVirtualLiveLab:mainVirtualLiveLab/python-template:mainfrom
y-chan:ci/auto-releasey-chan/python-template:ci/auto-releaseCopy head branch name to clipboard
Open

自動リリースworkflowを追加#3
y-chan wants to merge 10 commits intoVirtualLiveLab:mainVirtualLiveLab/python-template:mainfrom
y-chan:ci/auto-releasey-chan/python-template:ci/auto-releaseCopy head branch name to clipboard

Conversation

@y-chan
Copy link

@y-chan y-chan commented Jul 15, 2024

close #1

srcをパッケージングしたけど、これpyproject.tomlとか含める必要ない...?

サンプルはここ: https://github.com/y-chan/python-template/releases/tag/0.0.2

@y-chan y-chan linked an issue Jul 15, 2024 that may be closed by this pull request
4 tasks
Copy link
Member

@sushichan044 sushichan044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

骨子は問題ないと思います!

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
sushichan044

This comment was marked as duplicate.

@sushichan044
Copy link
Member

sushichan044 commented Jul 15, 2024

#2 でghalintの警告を直します

@sushichan044
Copy link
Member

pyproject.tomlを含めるかどうかは確認がいりそうなのでしておきます

y-chan and others added 2 commits July 16, 2024 02:03
Co-authored-by: Kentaro Suzuki <mail@sushichan.live>
@sushichan044
Copy link
Member

sushichan044 commented Jul 15, 2024

メモ
pyproject.tomlのversionを手動で変更してはいけないことをREADMEに書く
別のPRでも良さそう

=> #4 でやります

Copy link
Member

@sushichan044 sushichan044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@sushichan044
Copy link
Member

よく考えたらsrcごと配布するより(cd src && zip -r hoge.zip .)みたいな風に配布した方が
zipファイル解凍したときに余分なディレクトリができなくて良い気がしている

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

自動リリース用Workflowの整備

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.