vmselect: slightly improve allocation pattern #9673
Conversation
|
btw starting from go1.22 allocating VictoriaMetrics/app/vmselect/netstorage/netstorage.go Lines 3294 to 3297 in b6bacda according to the issue golang/go#75209 (comment) there are no plans to restore this behavior cc @valyala |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## cluster #9673 +/- ##
===========================================
- Coverage 59.08% 52.97% -6.11%
===========================================
Files 416 532 +116
Lines 78511 86388 +7877
===========================================
- Hits 46385 45763 -622
- Misses 29567 38190 +8623
+ Partials 2559 2435 -124 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Could you please provide results of test Benchmarks with improved memory allocations? Or add a new Benchmark to validate this change. |
Happy to add a new one. Could you help me with what it might look like? |
Describe Your Changes
These changes reduce allocation rate and gc pressure by about 10%.
sum(rate(go_memstats_alloc_bytes_total{job="vmselect"}[5m]))sum(rate(go_gc_cpu_seconds_total{job="vmselect"}[5m]))Our setup:
vmselect v1.120.0-cluster 14 pods x 15CPU x 60Gi configured with 100 vmstorage nodes
~ 500rps mostly alerting and recording rules
Checklist
The following checks are mandatory: