feat:add pop-up notification for empty API configuration#493
Open
DerenZhang wants to merge 2 commits intoValueCell-ai:mainValueCell-ai/valuecell:mainfrom
DerenZhang:feat/api_missing_notificationDerenZhang/valuecell:feat/api_missing_notificationCopy head branch name to clipboard
Open
feat:add pop-up notification for empty API configuration#493DerenZhang wants to merge 2 commits intoValueCell-ai:mainValueCell-ai/valuecell:mainfrom DerenZhang:feat/api_missing_notificationDerenZhang/valuecell:feat/api_missing_notificationCopy head branch name to clipboard
DerenZhang wants to merge 2 commits intoValueCell-ai:mainValueCell-ai/valuecell:mainfrom
DerenZhang:feat/api_missing_notificationDerenZhang/valuecell:feat/api_missing_notificationCopy head branch name to clipboard
Conversation
vcfgv
reviewed
Dec 2, 2025
| @@ -61,52 +40,18 @@ async def get_app_info(): | ||
| ) | ||
| async def health_check(): | ||
| """Service health status check.""" | ||
| config_manager = ConfigManager() | ||
| enabled_providers = config_manager.get_enabled_providers() |
Collaborator
There was a problem hiding this comment.
healthz is a high-frequency endpoint. We shouldn't include such a heavy query here.
Collaborator
|
In addition, this PR should not close #366 since it may not fully resolve it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Pull Request Template
1. Related Issue
Closes #366
2. Type of Change (select one)
Type of Change: New feature
3. Description
Adds a warning banner that notifies users when no LLM API keys are configured in their
.envfile.4. Testing
5. Checklist