fix: handling path containing url unicode chars #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+15
to
+21
| @pytest.mark.parametrize( | ||
| ("remote_url", "expected_path"), | ||
| [ | ||
| ("dropbox://da ta", "da ta"), | ||
| ("dropbox://da%20ta", "da ta"), | ||
| ], | ||
| ) |
There was a problem hiding this comment.
What if my dropbox folder is named "a%20b" (literal name, not encoded)? Will it return a%20b or a b?
|
@mateuszkuprowski I think we can close this PR now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix should allow fsspec connector to correctly handle paths containing whitespace and other url like characters like: %20.
Also slightly improved error logging for debug purposes.