Make Post-processing passes rendergraph ready #963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienIgnace-Unity
approved these changes
Jun 18, 2020
Contributor
JulienIgnace-Unity
left a comment
There was a problem hiding this comment.
Looks good to me.
Lots of unrelated whitespace changes though (parameter alignment mostly).
Contributor
Author
Tried to realign now |
…cessing-render-graph-step1 # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/PostProcessing/PostProcessSystem.cs
sebastienlagarde
approved these changes
Jun 18, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step to make the passes of post-processing render graph ready.
This is essentially changing the pattern of them so that they fit what rendergraph expects, some are changed more dramatically than others.
Skipped DoF for now since it is undergoing some changes.
I tested simple scenes with a bunch of the affected post processing passes in and ran the post processing visual tests.
Yamato: https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/HDRP%252Fpost-processing-render-graph/.yamato%252Fall-hdrp.yml%2523All_HDRP_fast-trunk/2571033/job