Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[22.1][Built-in] Moving WS view direction from vertex to fragment to lower varying size #6542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sebastienlagarde merged 1 commit into from
Dec 13, 2021
Merged

[22.1][Built-in] Moving WS view direction from vertex to fragment to lower varying size #6542

sebastienlagarde merged 1 commit into from
Dec 13, 2021

Conversation

@skerys
Copy link
Contributor

@skerys skerys commented Dec 9, 2021

Purpose of this PR

Backport of #6512

Testing status

tested the BuiltinGraphicsTest_Lighting project locally
PR Shadergraph + ShaderGraph_BuiltIn_Lighting in yamato

@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/jobDefinition/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/jobDefinition/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/jobDefinition/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@peterjohnlong
Copy link
Contributor

peterjohnlong commented Dec 9, 2021

Sorry I accidently added backport labels to the wrong PR, I removed them again. Sorry!

@skerys skerys marked this pull request as ready for review December 9, 2021 16:15
@skerys skerys requested a review from a team as a code owner December 9, 2021 16:15
jessebarker
jessebarker approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@jessebarker jessebarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skerys
Copy link
Contributor Author

skerys commented Dec 10, 2021

ShaderGraph on Linux_Vulkan_Standalone_mono_Linear, ShaderGraph on Win_DX11_Standalone_mono_Linear and VFX_URP on Win_DX11_playmode_mono_Linear are failing in 2022.1/staging too, all other tests passed

@sebastienlagarde sebastienlagarde merged commit 76bb39b into 2022.1/staging Dec 13, 2021
@sebastienlagarde sebastienlagarde deleted the 2022.1/shadergraph/builtin-world-space-view-dir-to-frag branch December 13, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jessebarker jessebarker jessebarker approved these changes

Assignees

No one assigned

Labels

Shader Graph

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skerys @peterjohnlong @jessebarker @sebastienlagarde
Morty Proxy This is a proxified and sanitized view of the page, visit original site.