Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

commited updated materials to fix test issue #6540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phi-lira merged 1 commit into from
Dec 9, 2021
Merged

commited updated materials to fix test issue #6540

phi-lira merged 1 commit into from
Dec 9, 2021

Conversation

@martint-unity
Copy link
Contributor

@martint-unity martint-unity commented Dec 9, 2021

Purpose of this PR

Fixing failing tests
Test named 104_Decal_and_... has a guid change that needed fixing.
Updating materials and assets to latest

Testing status

Ran Yamato Nightly to check that this passed.
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/vfx%252Fvfx-urp-test-failure-fix/.yamato%252Fall-vfx.yml%2523VFX_trunk/10361809/job

@martint-unity
commited updated materials to fix test issue
ae7b1c2 
Also 104_Decal_and_... has a guid change that needed fixing.
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

VFX
/jobDefinition/.yamato%252Fall-vfx.yml%2523PR_VFX_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

github-actions bot commented Dec 9, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

PaulDemeulenaere
PaulDemeulenaere approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's only updating data, it looks good to me.

@phi-lira phi-lira changed the base branch from master to universal/staging December 9, 2021 09:25
@phi-lira phi-lira merged commit c9b644d into universal/staging Dec 9, 2021
@phi-lira phi-lira deleted the vfx/vfx-urp-test-failure-fix branch December 9, 2021 09:25
@phi-lira phi-lira mentioned this pull request Dec 9, 2021
Merged
2 tasks
hazelbit added a commit that referenced this pull request Dec 9, 2021
@hazelbit
Merge master to fix VFX_URP on Win_DX11_playmode_mono_Linear (#6540)
6f38328
@phi-lira phi-lira mentioned this pull request Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PaulDemeulenaere PaulDemeulenaere PaulDemeulenaere approved these changes

+1 more reviewer

@phi-lira phi-lira phi-lira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testing vfx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martint-unity @phi-lira @PaulDemeulenaere
Morty Proxy This is a proxified and sanitized view of the page, visit original site.