Changes for using Embedded IR Tokens #6348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-davis
approved these changes
Nov 19, 2021
Contributor
joshua-davis
left a comment
There was a problem hiding this comment.
My only worry is that you left AppendScopeName alone which has the hardcoded "Block" string which has to match how the ShaderBuilder is doing things. Not a blocker, but would be nice if we can guarantee these strings will be identical.
joshua-davis
approved these changes
Nov 23, 2021
Contributor
joshua-davis
left a comment
There was a problem hiding this comment.
Good enough. We can worry about the declaration of the namespace at a later point.
joshua-davis
pushed a commit
that referenced
this pull request
Feb 2, 2022
* Changes for using Embedded IR Tokens * Missing function * Updating to call ShaderBuilder.DeclareStruct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.