Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Added package samples documentation to URP #5822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JordanL8 merged 4 commits into from
Oct 4, 2021
Merged

Added package samples documentation to URP #5822

JordanL8 merged 4 commits into from
Oct 4, 2021

Conversation

@JordanL8
Copy link
Contributor

@JordanL8 JordanL8 commented Sep 28, 2021

Purpose of this PR

Adds documentation on package samples in URP.

@JordanL8 JordanL8 requested a review from phi-lira September 28, 2021 12:49
@JordanL8 JordanL8 requested review from a team as code owners September 28, 2021 12:49
@github-actions
Copy link

github-actions bot commented Sep 28, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

github-actions bot commented Sep 28, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@phi-lira phi-lira requested review from Jonasmortensen and removed request for phi-lira September 29, 2021 13:06
erikabar
erikabar approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@erikabar erikabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Jonasmortensen
Jonasmortensen approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@Jonasmortensen Jonasmortensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor typo

Started a discussion about some additional points with the author but no shipstoppers.

com.unity.render-pipelines.universal/Documentation~/package-sample-urp-package-samples.md Outdated Show resolved Hide resolved
@JordanL8 JordanL8 merged commit d6fbc5e into master Oct 4, 2021
@JordanL8 JordanL8 deleted the urp/docs/doc-3439-package-samples branch October 4, 2021 12:30
@JordanL8 JordanL8 mentioned this pull request Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Jonasmortensen Jonasmortensen Jonasmortensen approved these changes

@erikabar erikabar erikabar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported-2021.2 Docs universal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JordanL8 @Jonasmortensen @erikabar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.