Fix APV debug using profile and not baked data + small probe volume init #5632
Conversation
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. SRP Core Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
| static void Drawer_VolumeContent(SerializedProbeVolume serialized, Editor owner) | ||
| { | ||
| if (!ProbeReferenceVolume.instance.isInitialized) | ||
| if (!ProbeReferenceVolume.instance.isInitialized || !ProbeReferenceVolume.instance.enabledBySRP) |
There was a problem hiding this comment.
When can this happen?
Start with APV enabled in the asset then switch it off?
Sounds like we should cleanup the APV in this case no?
There was a problem hiding this comment.
It can be valid but not enabled by current frame settings
There was a problem hiding this comment.
Ah right, forgot about the frame settings and thought it was only the global settings.
This PR has a fix for the debug view using the wrong cell size for baked data that lead to wrong visualization.
Instead we grab the actually loaded info if we are displaying data for baked data, otherwise we use the info from the profile for realtime subdivision debug view.
The PR has also another small check for probe volume UX if the feature gets disabled.