Fix rendergraph failing after several minutes (due to hash returning 0 as valid index bit) #2172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
JulienIgnace-Unity
approved these changes
Oct 12, 2020
sebastienlagarde
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a fun one D: Fixes the issue that reproes every several minutes.
Essentially we use an hash to determine the validity of a resource. Each frame the value that is considered valid changes, however up until this fix 0 could have been selected as a value that is valid, depending on how the frame index is hashed.
HOWEVER, 0 is also used as a flag value to determine that an handle is invalid, so if the hash returned 0 as valid index, the resource would still be marked as invalid even though it isn't.