Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@marctem
Copy link
Contributor

@marctem marctem commented Apr 16, 2020

An engine change broke our support for selecting a custom mesh in the master preview. Very minor change to use the correct API again.

  • Have you updated the changelog? Each package has a CHANGELOG.md file.

Testing status

I opened a graph, right-clicked the master preview, and selected a custom mesh. No more error, it loads the mesh as it used to.

Not running full test pass as this change is so small, just verify it fixes the bug and we're good to merge.

@marctem marctem requested a review from alindmanUnity April 16, 2020 20:08
@marctem marctem requested review from a team as code owners April 16, 2020 20:08
@marctem marctem changed the title [Backport 8.x.x][skip-ci] Fix custom mesh support in the Master Preview [Backport 8.x.x][skip ci] Fix custom mesh support in the Master Preview Apr 16, 2020
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem confirmed fixed

@marctem marctem merged commit 02ffea0 into 8.x.x/release Apr 16, 2020
@marctem marctem deleted the 8.x.x/sg/fix-custom-mesh branch April 16, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.